Summary: | .tag files in a .tar recompiled for each .jsp -- extremely slow (with fix) | ||
---|---|---|---|
Product: | Tomcat 6 | Reporter: | Anthony Berglas <aberglas> |
Component: | Jasper | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | P2 | ||
Version: | 6.0.9 | ||
Target Milestone: | default | ||
Hardware: | All | ||
OS: | All |
Description
Anthony Berglas
2007-10-30 21:10:48 UTC
I'd much rather fix the cause than the symptom. The proper fix for this will be to implement the enhancement described in bug 43742. I'll check the code to see if the JSP -> JAR dependency has been fixed (and if it hasn't - fix it) but if you have a bug number that would save me some time. I have looked at this some more. I think your patch is pretty much spot on. Generally, if a JAR changes, the app needs to be re-loaded (eg using reloadable or watched resources). That is true for any other JAR and I don't see why it shouldn't be true for JARs containing tag files. Compiling tags in a single pass (bug 43742) would also help. Bug 43878 will also contribute to poor performance, although in a different way. Your patch has been applied to trunk and proposed for 6.0.x. My relaoding comment is wrong. The app needs to be redployed (ie the work dir cleared as pointed out in the original report). I have reverted the patch and am working on one that handles tags in JARs. I have a proper fix for this now: http://svn.apache.org/viewvc?rev=618481&view=rev It has been committed to trunk and proposed for 6.0.x This has been committed to 6.0.x and will be in 6.0.17 onwards. |