Bug 48501

Summary: Log rotation for ISAPI Redirector
Product: Tomcat Connectors Reporter: Tim Whittington <Tim.Whittington>
Component: isapiAssignee: Tomcat Developers Mailing List <dev>
Status: RESOLVED FIXED    
Severity: enhancement    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X 10.4   
Attachments: PATCH - ISAPI Redirector with rotatelogs functionality
PATCH - ISAPI Redirector doc updates
PATCH - ISAPI Redirector with rotatelogs functionality
PATCH - ISAPI Redirector with rotatelogs functionality

Description Tim Whittington 2010-01-07 00:48:53 UTC
Created attachment 24810 [details]
PATCH - ISAPI Redirector with rotatelogs functionality

Apache supports log rotation through piped logging to the rotatelogs program.

Attached are patches to provide equivalent functionality in the IIS ISAPI Redirector.
Comment 1 Tim Whittington 2010-01-07 00:49:51 UTC
Created attachment 24811 [details]
PATCH - ISAPI Redirector doc updates
Comment 2 Mladen Turk 2010-01-07 01:09:27 UTC
_ftell_nlock does not exist with older MSVC versions.
It was introduced with Visual Studio 2005
Comment 3 Tim Whittington 2010-01-07 01:24:41 UTC
Created attachment 24812 [details]
PATCH - ISAPI Redirector with rotatelogs functionality

Updated the patch to only use _ftell_nolock when available.
Comment 4 Tim Whittington 2010-01-07 12:40:08 UTC
Created attachment 24815 [details]
PATCH - ISAPI Redirector with rotatelogs functionality

Attached updated patch with a couple of changes:
* Using GetFileSizeEx on suggestion from Mladen (fixes log size determination with multiple IIS processes and adds 64bit file size support)
* Added support for optional use of an M suffix on log_filesize setting, as used in rotatelogs

(Combined doc updates into this patch as well)
Comment 5 Tim Whittington 2010-03-07 20:46:04 UTC
Implementation of this is now committed to trunk.
Comment 6 Mark Thomas 2011-03-07 05:06:40 UTC
This was included in 1.2.31 onwards