| Summary: | Mark commons-logging and log4j as optional dependencies in pom.xml-s | ||
|---|---|---|---|
| Product: | POI | Reporter: | Attila Király <kiralyattila.hu> |
| Component: | POI Overall | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 3.7-dev | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
Attila Király
2010-10-09 11:48:04 UTC
Thanks for the suggestion. I marked commons-logging and log4j as optional in r1021326. The upcoming POI-3.7 will include this fix. We will consider upgrade to the latest versions of these libraries in POI-3.8. Yegor Thanks for the quick fix but this should be done in poi-scratchpad.pom file too. (In reply to comment #2) > Thanks for the quick fix but this should be done in poi-scratchpad.pom file > too. Good catch, thanks. Aren't these dependencies extra in poi-scratchpad.pom? I'm not a Maven expert and your expertise is greatly appreciated. I think poi-scratchpad should be able to access log4j and commons-logging via the dependency in the main pom. With this in mind, should we remove log4j and commons-logging from poi-scratchpad.pom? Yegor (In reply to comment #3) > (In reply to comment #2) > > Thanks for the quick fix but this should be done in poi-scratchpad.pom file > > too. > > Good catch, thanks. > > Aren't these dependencies extra in poi-scratchpad.pom? I'm not a Maven expert > and your expertise is greatly appreciated. > > I think poi-scratchpad should be able to access log4j and commons-logging via > the dependency in the main pom. With this in mind, should we remove log4j and > commons-logging from poi-scratchpad.pom? > > Yegor You are right you can remove them. poi-scratchpad depends on poi so there is no need to redefine those dependencies. |