| Summary: | Add support for error-pages to CGIServlet | ||
|---|---|---|---|
| Product: | Tomcat 8 | Reporter: | apache |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | P2 | ||
| Version: | 8.0.x-trunk | ||
| Target Milestone: | ---- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Attachments: | Patch for applying the enchancement described in the report. Adds a new init-param to the servlet configuration which will be used to trigger the error-page mechanism. | ||
Is there anything additional that I need to do in order to have this patch either accepted or declined? I am curious because I have not seen any activity on this in the last three months. Thanks. See http://markmail.org/message/l7d242gtzamednke In short, this is waiting for a committer to take the time to think this request through and make sure that it makes sense. I'm seeing the same issue and it would be good to get this merged instead of having to build and deploy custom Tomcats I've had a look at this request. I'm currently leaning towards using the debug level to determine whether to use setStatus() or sendError() rather than a new configuration setting. I'll document that setting debug >= 10 will disable custom error pages and show debug pages instead. Probably with a further comment not to use this setting in production. Looking at the docs, some further explanation of what the signfificant values for debug are (once I've worked them out) wouldn't go amiss either. As of 8.0.25, the CGI servlet will use the standard error page mechanism unless the debug attribute is 10 or less. (In reply to Mark Thomas from comment #5) > As of 8.0.25, the CGI servlet will use the standard error page mechanism > unless the debug attribute is 10 or less. Thanks Mark! Appreciate the help. |
Created attachment 32591 [details] Patch for applying the enchancement described in the report. Adds a new init-param to the servlet configuration which will be used to trigger the error-page mechanism. A configuration parameter has been added to the CGIServlet to allow use of the error-page mechanism. Default configuration will maintain current functionality. Currently, when the debug logging level is too low and there is an error executing the CGI script, a blank page is returned even if the corresponding error-page is configured correctly. This causes inconsistency with custom error-pages.