Summary: | Performance regression: DataFormatter no longer caches formats | ||
---|---|---|---|
Product: | POI | Reporter: | Nick C <fxfixer> |
Component: | SS Common | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | regression | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | All |
Description
Nick C
2016-04-26 20:32:02 UTC
getFormat caches data format in r1741114. Skimming the code, createFormat does not cache data format. Would caching the format returned by createFormat improve the speed over previous builds? If not, should createFormat be static? I patched my local copy and one excel file with over 400K rows with dates and numbers went from taking 1.5 minutes to 30ish seconds. Sadly when you have lots of large excel files it adds up. Could you attach your patch? The patch I had was the same as what you applied in r1741114. Thanks for making the fix so quickly. Was a released poi version affected by this? Or was it only the current trunk? The regression was introduced on 2015-10-25, so POI 3.14-beta1 through 3.15-beta1 were affected. Search for bug 58532 on https://poi.apache.org/changes.html |