Summary: | [PATCH] Remove use of obsolete Hashtable class | ||
---|---|---|---|
Product: | POI | Reporter: | Axel Howind <axel> |
Component: | POI Overall | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | axel |
Priority: | P2 | ||
Version: | 3.15-dev | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | Replace Hashtable by HashMap, LinkedHashMap |
Description
Axel Howind
2016-06-23 21:27:51 UTC
Looks okay to me. We should add key-value generic type when missing. Public methods should return a new map or wrap the map with Collections.unmodifiableMap. Applied in r1750168. This commit made no attempt to keep public API's available (but deprecated). I fixed TestContentType to not rely on the Map ordering and used a HashMap instead of a LinkedHashMap. (In reply to Javen O'Neal from comment #2) > This commit made no attempt to keep public API's available (but deprecated). Any implementation that relied on method arguments being Hashtable will also work with Map method arguments, so no need to add deprecated Hashtable methods. Replaced Hashtable usage in contrib/poi-ruby in r1750182. |