Bug 60520

Summary: SS Common classes for *SSF shapes
Product: POI Reporter: Andreas Beeker <kiwiwings>
Component: SS CommonAssignee: POI Developers List <dev>
Severity: enhancement    
Priority: P2    
Version: 3.16-dev   
Target Milestone: ---   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60519, 60521    
Attachments: common interfaces for shapes and shape groups

Description Andreas Beeker 2016-12-26 23:13:50 UTC
Created attachment 34556 [details]
common interfaces for shapes and shape groups

The embedding patch #60519 is depending on those common interfaces for shapes and shape groups.

To document the changes better (in the changes file), I've splitted the changes apart.

Similar to Common SL, I only provided interfaces instead of abstract classes - this keep the implementation simpler ...
Comment 1 Andreas Beeker 2016-12-26 23:28:34 UTC
This patch also handles AlternateContent elements in OOXML drawings.
The problem with this approach is, that XMLBeans doesn't allow the cast (via changeType/substitute) of Choice elements to CT_Drawing, therefore the source needs to be parsed again ... but the newly parsed objects aren't linked anymore to the original xml source, therefore changes to those elements are futile.
A solution might be, to identify those AlternateContent tags on writing and to update the child elements from the shadow copy ... but this is not part of the patch.
Comment 2 Andreas Beeker 2016-12-31 21:59:01 UTC
Applied via r1776818