Summary: | Change log level of sessionIdGeneratorBase.createRandom to warn rather than info | ||
---|---|---|---|
Product: | Tomcat 8 | Reporter: | Coty Sutherland <csutherl> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | trivial | Keywords: | Beginner |
Priority: | P2 | ||
Version: | 8.0.x-trunk | ||
Target Milestone: | ---- | ||
Hardware: | All | ||
OS: | All |
Description
Coty Sutherland
2017-06-12 19:19:44 UTC
This is the definition of a "Beginner" issue IMO :) Hi, I'm newby as a tomcat contributor and I'd like to take this issue. Taking another look at the code around the info message I think we may need to add another check to see if the delay time is larger than 100 ms. If we make this a warning message as-is I think that everyone's log may have a warning in it. Should we print an info message if the delay is less than some number (like 30 seconds) and a warning if the delay is greater? I don't see the message on my new(ish) desktop nor my old(ish) laptop. If the threshold is too low for some systems, we can look at increasing it. My instinct is that 100ms will be plenty of time for that block of code unless there is an entropy problem, I also took the opportunity to clean up some formatting and I added a changelog entry. Thanks to Piotr Chlebda for the patch. Fixed in: - trunk for 9.0.0.M22 onwards - 8.5.x for 8.5.16 onwards - 8.0.x for 8.0.45 onwards - 7.0.x for 7.0.79 onwards 1) Would that be another bug for that ? 2)I'd like to make sure that my PR was ok, since it was only at trunk (version 9). Are there any requirments for PR for other version(8.5.x,8.0.x,7.0.x) ? (In reply to Piotr Chlebda from comment #5) > 1) Would that be another bug for that ? Maybe. We need to wait and see if we get any such reports. I'd be surprised to get such a report where there wasn't an underlying entropy problem. > 2)I'd like to make sure that my PR was ok, since it was only at trunk > (version 9). Are there any requirments for PR for other > version(8.5.x,8.0.x,7.0.x) ? Bug fixes to trunk are back-ported to earlier versions. The back-ports normally apply cleanly so no further work is required. It would be helpful to include a changelog entry when you fix a bug. It saves the committers a few minutes writing it themselves. Thanks Mark Thomas for a quick response. |