Summary: | SMTPSampler does not allow configuring the SSL/TLS protocols to be used on handshake | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Felipe Cuozzo <felipe.cuozzo> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | felipe.cuozzo, p.mouawad |
Priority: | P2 | Keywords: | FixedInTrunk, PatchAvailable |
Version: | 4.0 | ||
Target Milestone: | JMETER_5.0 | ||
Hardware: | All | ||
OS: | All |
Description
Felipe Cuozzo
2018-08-03 05:06:22 UTC
I've a proposed patch on https://github.com/fcuozzo/jmeter/commit/f7c27b90beb3decacbfc9b19b755954892e829c0 Author: pmouawad Date: Sat Aug 4 18:46:53 2018 New Revision: 1837445 URL: http://svn.apache.org/viewvc?rev=1837445&view=rev Log: Bug 62595 - SMTPSampler does not allow configuring the SSL/TLS protocols to be used on handshake Contributed by Felipe Cuozzo Bugzilla Id: 62595 Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SecuritySettingsPanel.java jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java jmeter/trunk/xdocs/changes.xml jmeter/trunk/xdocs/usermanual/component_reference.xml Thanks for contributing. This will be available in next JMeter 5.0. Meanwhile if you can test nightly build after today and give us feedback it would be nice. http://jmeter.apache.org/nightly.html Thanks Regards Hi Phillipe, Thank you for the fast turn-around here. After testing the nightly build I realized I forgot to push a one line change to the SmtpSampler I had on my local repository. Please see extra commit on https://github.com/fcuozzo/jmeter/commit/680f16dd1013d2bc5f1da2b4f1cf5a609e47a9e3 Without that the custom protocols don't actually get set into the SendEmailCommand so the new behavior does not work. Thanks for the refactoring and changing to use StringUtils.isEmpty to check if the String was empty (my bad there, I should have checked what was the common pattern in the codebase, my previous logic had a NullPointerException bug lurking in there). Thanks, Felipe Thanks for the followup. Could you try the next nightly, if thinks work for you then? Date: Thu Aug 9 09:19:43 2018 New Revision: 1837704 URL: http://svn.apache.org/viewvc?rev=1837704&view=rev Log: Bug 62595 - SMTPSampler does not allow configuring the SSL/TLS protocols to be used on handshake Followup to r1837445. Missing the line to actually use the settings for sending mails. Contributed by Felipe Cuozzo Bugzilla Id: 62595 Modified: jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/SmtpSampler.java This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4834 |