Summary: | [PATCH] Record 1C1h (RecalcId) | ||
---|---|---|---|
Product: | POI | Reporter: | Luc Girardin <luc.girardin> |
Component: | HSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | luc.girardin |
Priority: | P3 | ||
Version: | 2.0-dev | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Patch to Workbook and RecordFactory classes
RecalcIdRecord.java |
Description
Luc Girardin
2002-10-10 16:13:20 UTC
Created attachment 3412 [details]
Patch to Workbook and RecordFactory classes
Created attachment 3413 [details]
RecalcIdRecord.java
I hope you resubmit this, but after applying it the SST Record unit test fails. Please run ./build.sh clean compile test, resolve and resubmit. or run ./build.sh clean compile site (then view the html report which has hte stacktrace) Thanks, Andy I hope you resubmit this, but after applying it the SST Record unit test fails. Please run ./build.sh clean compile test, resolve and resubmit. or run ./build.sh clean compile site (then view the html report which has hte stacktrace) Thanks, Andy Hmmm... I did run the JUnit tests (before sending the patch and again today) and no error has been detected. I also quickly double-checked the patch I sent and it looks complete. Could you please give it another try? I did again verify my patch and it seems valid. applied. My appologies. This must have been during my encoding issue. It would be good if you could submit a unit test for the RecalcIdRecord and maybe even for the conditions for Workbook. (if Recalc..then bla, if not then bla) It would appear that when this patch was committed, RecalcIdRecord.java was not added to CVS. Paul, you are right. I added RecalcIdRecord.java to the CVS. This one might also be interesting: [RECALCID] .reserved = 0x0000 .engineId = 0x00013880 [/RECALCID] Question: How do I create an RecalcIdRecord? The only available constructor requires a RecordInputStream? (In reply to comment #10) > This one might also be interesting: > > [RECALCID] > .reserved = 0x0000 > .engineId = 0x00013880 This means do not recalulcate - see the first comment > Question: How do I create an RecalcIdRecord? The only available constructor > requires a RecordInputStream? Currently you can't add one to a new file. Wouldn't be too hard to add though, please open a new bug if you'd like to work on this |