| Summary: | [PATCH] HSSFHeader and HSSFFooter doesnot support for my native language | ||
|---|---|---|---|
| Product: | POI | Reporter: | jerry <unidevel> |
| Component: | HSSF | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED INVALID | ||
| Severity: | critical | ||
| Priority: | P3 | ||
| Version: | 2.0-dev | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | other | ||
| Attachments: |
Here is a test program and a test excel file, it will output two excel file
Fixed to support multibyte String value of sheet's footer. Fixed to support multibyte String value of sheet's header. Fixed the probrem BoundSheetRecord#setSheetsName() is not synchronize between sheetname and unicode flag. PATCH for FooterRecord and HeaderRecord general class for string length less than 2^31-1 org.apache.poi.hssf.record.StringValue2 general class for string length less than 255 org.apache.poi.hssf.record.StringValue1 HeaderRecord.java rewriten using StringValue2 I make testcase for "this" problem. If sheet's header and footer has DBCS,assertions are failed. |
||
|
Description
jerry
2002-11-21 13:02:09 UTC
can you submit (click create a new attachment): 1. A minimal spreadsheet with a chinese header and footer 2. The minimum amount of code necessary to reproduce this problem? (code that tries to set a chinese header and footer) -Andy Created attachment 3916 [details]
Here is a test program and a test excel file, it will output two excel file
Hello, I'm Japanese programmer(sorry I can't write english well,so I may make incorrect expressions…)working with this useful library. Thank you for your good effort. I found the reason of the bug in library's source code. org.apache.poi.hssf.record.HeaderRecord and org.apache.poi.hssf.record.FooterRecord, as concrete record classes of thease Objects,Excel sheet's header and footer, are not support String having some multibyte characters.In thease classes,String value is always compressed and lost high byte of Unicode character. And I found, because of same reason, org.apache.poi.hssf.record.BoundSheetRecord is not support multibyte String, so I can't use multibyte String to Excel sheet's name. Now I'm using library that I fixed thease problems in my local environments. Please fix thease classes in your repository. Created attachment 3963 [details]
Fixed to support multibyte String value of sheet's footer.
Created attachment 3964 [details]
Fixed to support multibyte String value of sheet's header.
Created attachment 3965 [details]
Fixed the probrem BoundSheetRecord#setSheetsName() is not synchronize between sheetname and unicode flag.
Thanks for fixing it, I hava tested it with several template, it works. Sorry, my attatchments are not best solution,but only solved our problems. I think the best solution is,not having by raw String instance,but delegate to some abstract String object,like org.apache.poi.hssf.record.UnicodeString. I expect thease classes are fixed to good implementation. ensure you put [PATCH] before patches or I won't notice them... Don't close it unless its been applied. Please resubmit with PATCHES instead of the complete files. It like next to never works when I have to figure out what is different between a complete file. See instructions (near the end) http://jakarta.apache.org/poi/getinvolved/index.html. Resubmit per the instructions and reopen. Thanks. Created attachment 4013 [details]
PATCH for FooterRecord and HeaderRecord
Sorry I didn't understand the rules for submit patches. I generated.Please check it. I write a general String class for this problem. StringValue2 for string length is a short value and StringValue1 for string length is a byte value. I rewrite the HeaderRecord using StringValue2 class. Created attachment 4104 [details]
general class for string length less than 2^31-1 org.apache.poi.hssf.record.StringValue2
Created attachment 4105 [details]
general class for string length less than 255 org.apache.poi.hssf.record.StringValue1
Created attachment 4106 [details]
HeaderRecord.java rewriten using StringValue2
Please resubmit this as a PATCH against the HEAD per the instructions here: http://jakarta.apache.org/poi/getinvolved/index.html. Ensure that all unit tests pass and consider writing one that replicates the conditions you've fixed. (which should fail without the patch but succeed after it has been applied). Created attachment 4156 [details]
I make testcase for "this" problem. If sheet's header and footer has DBCS,assertions are failed.
Ahh okay I see now. There is a patch for header record. I'm not sure what the second header record is... Which of these should I apply? My patch looks like "first aid" for this problem. But the implementation Mr.qiuyping? wrote are not only solve this,but may make other i18n problems to solve easily.(I don't know his classes are correct for other Record classes or not...) So if you adopt his implementation and plan(replace from raw String object to his classes),please ignore my patch. lets reopen another bug and attach only the patches which can be applied especially w/breaking something else. Hmm… OK,I'll reopen this problem as a new bug [HSSFHeader and HSSFFooter doesnot support DBCS],and resubmit only my testcase and pathces,which will simply solve this without breaking something else. Please wait a moment. |