Summary: | [PATCH] formula fixes for IF support, conditionals, string handling | ||
---|---|---|---|
Product: | POI | Reporter: | fred |
Component: | HSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | avik |
Priority: | P3 | ||
Version: | 2.0-dev | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | diff -u requested, note does not include new files (second try) |
Description
fred
2003-04-16 16:55:47 UTC
oooh, thanks for taking care of this ugly work. can you click "Create a new attachment" to attach files from now on? can you use 'cvs diff -u' for creating a patch? we would also love for you to create testcases. we have a conditionals patch that's only missing testcases as a reason for not being committed. we need to make sure any new formulaparser changes do not break the fixes you provided. I can't tell from this if the diff -u attachment was sucessful. If not I will try again. The diff -u does not appear to include the new files. Also test cases is a little more difficult. I have a wrapper that generates a spreadsheet from a database query, but does things like get the cell types correct and supports formulas. My test cases are currently in XML and run through a converter that translates R1C1 format to cell names and generates a conditional. So I can't really just give you the 6 or so test cases that I already have. I will look into generating a couple though. Created attachment 5868 [details]
diff -u requested, note does not include new files (second try)
the unified patch looks good...usually you have to tar/zip up the new files. testcases are pretty simple for formulas..typically we usually check if the ptgs are generated as expected. TestFormulaParser has a lot of examples. If you have 6 testcases, i'm assuming that's 6 different formulas you're testing. worst case scenario, 6 new methods to write ;). thanks! Danny, are you going to commit this? Given that this did not have patch in its title, i missed it while doing the other bug. I can do this tomorrow for sure , unless you beat me to it. Given my previous commit, which surely clash with this one, it seems that, again, this patch will have to be applied line by line!! Yeah I've been feeling naughty and will commit this. I'll do the line by line and add test cases. I was going to remove the greater/less than stuff since we already had a patch for that. Committed with 2 test methods that test the new ptgs inside an embedded. Thanks for the contribution |