Bug 21863

Summary:	[PATCH] build.xml fixes
Product:	POI	Reporter:	Paul Krause <pkrause>
Component:	POI Overall	Assignee:	POI Developers List <dev>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	P3
Version:	3.0-dev
Target Milestone:	---
Hardware:	All
OS:	All
Attachments:	build.xml patch patch against HEAD [build.xml,v 1.48] patch against HEAD [build.xml,v 1.48] (2nd attempt)

Description Paul Krause 2003-07-24 19:31:18 UTC

Various minor fixes to build.xml.
1. fix path resolution so "ant -find build.xml test" from subdirectories works
2. fix failure property for test-scratchpad
3. add a target named clean-compile for the benifit of IDEs like JDeveloper 
which need such a thing

Comment 1 Paul Krause 2003-07-24 19:31:45 UTC

Created attachment 7499 [details]
build.xml patch

Comment 2 Avik Sengupta 2003-07-27 19:24:27 UTC

Small Q: whats the difference between value= and location= , which seems to be a
major part of the diff. 
my knowledge of ant seems to have been overtaken by the continuing evolution of
the product :)

Comment 3 Paul Krause 2003-07-28 05:05:41 UTC

value= Sets the property to the given string value.

location= Sets the property to the absolute filename of the given file. If the 
value of this attribute is an absolute path, it is left unchanged (with / and \ 
characters converted to the current platforms conventions). Otherwise it is 
taken as a path relative to the project's basedir and expanded.

The main point of this change is so the build can be run from other directories 
and still resolve paths correctly.

Comment 4 Avik Sengupta 2003-07-31 18:11:10 UTC

this didnt apply properly on head. Did u create this on branch?

Comment 5 Paul Krause 2003-08-04 14:25:20 UTC

The patch was created on HEAD, but build.xml has been modified at least twice 
since then.

Comment 6 Avik Sengupta 2003-08-04 14:34:34 UTC

would you mind creating another patch? I'll apply it immediately.

Comment 7 Paul Krause 2003-08-04 15:31:29 UTC

Created attachment 7645 [details]
patch against HEAD [build.xml,v 1.48]

Comment 8 Avik Sengupta 2003-08-04 17:13:27 UTC

[avik@localhost jakarta-poi-HEAD]$ cvs status build.xml
===================================================================
File: build.xml         Status: Up-to-date

   Working revision:    1.48
   Repository revision: 1.48    /home/cvs/jakarta-poi/build.xml,v
   Sticky Tag:          (none)
   Sticky Date:         (none)
   Sticky Options:      (none)

[avik@localhost jakarta-poi-HEAD]$ patch  build.xml  < build.diff
(Stripping trailing CRs from patch.)
patching file build.xml
Hunk #5 succeeded at 285 with fuzz 2.
missing header for context diff at line 182 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 182
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|
|      <target name="test-scratchpad"
depends="compile-scratchpad,-test-scratchpad-check"
unless="scratchpad.test.notRequired">
|!         <junit printsummary="yes" fork="no"
haltonfailure="${halt.on.test.failure}" failureproperty="scratchpad.test.failed">
|              <classpath>
|                  <path refid="scratchpad.classpath"/>
|                  <pathelement location="${main.output.dir}"/>
--------------------------
File to patch:

******************
:( Any ideas? Maybe u can just "cvs up" your build.xml and attach it here...
i'll commit that.

Comment 9 Paul Krause 2003-08-04 19:31:47 UTC

Created attachment 7647 [details]
patch against HEAD [build.xml,v 1.48] (2nd attempt)

Comment 10 Avik Sengupta 2003-08-23 19:10:34 UTC

applied to head. Please cross check. Thanks.