Summary: | [RFE] [PATCH] Support for Storage Class ID | ||
---|---|---|---|
Product: | POI | Reporter: | Michael Zalewski <zalewski> |
Component: | POIFS | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kimj |
Priority: | P3 | ||
Version: | 3.0-dev | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | other | ||
Attachments: |
diff and a new TestCase class (WinZip)
Diff and new TestCase against REL_2_BRANCH [PATCH] getters and setters for CLSID |
Description
Michael Zalewski
2003-08-07 04:01:50 UTC
Created attachment 7682 [details]
diff and a new TestCase class (WinZip)
Can you provide a patch against the REL_2_BRANCH. . This should go in the release as its pretty serious. (anyone disagree?) Hmmm. Might actually be against REL_2_BRANCH. I just pulled the default branch and made it this evening. But it don't have to go into Release 2. It really has no effect on HSSF, or anything else. If it were me, I would wait for Release 3, unless someone uses it to fix an actual problem. However, the new TestCase is against org.apache.poi.hpsf.ClassID, which formerly had no testcase. yes the head is rel 3. I'd like to use it for rel 2. Created attachment 7703 [details]
Diff and new TestCase against REL_2_BRANCH
*** Bug 24183 has been marked as a duplicate of this bug. *** I told Kirill on the other bug that he was too late for 2.0. But this one has been around for a while, and Andy mentioned he liked it for 2.0. What say folks, should we add this to 2.0? Since there is a testcase, maybe we should? Comitted. both to Branch and HEAD. Please cross-check, ClassID.java from the branch pathc didnt apply cleanly to HEAD, so I took that out of the HEAD patch attached to this bug. All tests pass in branch. The relevant tests pass on HEAD. Kirill, if you can get the gettter/setter in by end of friday, it might still go into the next release. Reopen this bug when you do. Thanks. Created attachment 8860 [details]
[PATCH] getters and setters for CLSID
Reopened: Added a patch with CLSID getters and setters for DirectoryNode and DirectoryEntry Comitted. Thanks. Please cross check. |