| Summary: | [PATCH] Added CLSID support for DirectoryNodes | ||
|---|---|---|---|
| Product: | POI | Reporter: | Kirill Jacobson <kimj> |
| Component: | POIFS | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | enhancement | ||
| Priority: | P3 | ||
| Version: | 2.0-pre3 | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | other | ||
| Attachments: |
[PATCH] CLSID support for DirectoryNodes
[PATCH] CLSID support for DirectoryNodes (without sun collections) |
||
Created attachment 8772 [details]
[PATCH] CLSID support for DirectoryNodes
Looks cool, but first reaction is, why the import for com.sun.java.util.collections.* ?? Oops, I forgot to replace this import back to java.utils. We use sun collections internaly. Should I submit another diff file? Created attachment 8807 [details]
[PATCH] CLSID support for DirectoryNodes (without sun collections)
Thanks.. we have a feature freeze for a release this weekend.. This will have to go in after the 2.0 release. Hey, is this the same as bug 22195 ? Sorry, we seem to have let that drop. Yes, this is the same bug as 22195 (from Rainer Klute). I think that his patch (not mine) should be used. It reuses poi/hpsf/ClassID class and has a testcase. The only thing that is missing in Rainer's patch are classID getters and setters for for DirectoryNode and DirectoryEntry. I will add them as soon as the Rainer's patch is commited to source branch. |
If you try to copy an Excel file with OLE objects (embeded, linked, commaind buttons, VBA macros) to another file using POI library then the links to these embeded objects are removed. Lets say you have Excel spreadsheet with a command button that associated with vba macro that pops up a message box. In the original Excel spreadsheet you click on the button, the vba code gets executed and message is displayed. You deep copy all the streams and storages from the original file to new compound storage file. You open this new file and you can see the button, but nothing happens if you click this button. It doesn't even change to pressed/unpressed state. This is beacause CLSIDs for the directories/storages are stripped out. I add getters and setters for CLSID to the Property object and DirectoryEntry inteface. They take CLSID as a string in the format that Windows Registry is using "{XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}" Kirill Jacobson www.SoftArtisans.com