|Summary:||SprmUtils.addSprm gets wrong instruction type|
|Product:||POI||Reporter:||Simon Niederberger <simon.niederberger>|
|Component:||HDF||Assignee:||POI Developers List <dev>|
Description Simon Niederberger 2003-12-28 14:05:37 UTC
From how I understand the code in SprmUtils.addSprm, the (instruction) type is derived from the highest three bits of the passed instruction. However, the bits are not right-shifted after the bit-and. int type = instruction & 0xe000; // SIN, ADD BEG // I guess the code is meant to read the top 3 bits and pack them in an int 0-7 type >>= 13; // SIN, ADD END (If this isn't bug report doesn't meet your standards, my apologies - just submitting my first one ...) Cheers Simon
Comment 1 Ryan Ackley 2003-12-28 14:35:31 UTC
Good catch. Oddly I had already fixed it on my local machine. I am actually working on HWPF this morning. Thanks for the bug report and keep them coming!!