Summary: | New 226 HTTP Response Code [PATCH] | ||
---|---|---|---|
Product: | Apache httpd-2 | Reporter: | James E. Robinson, III <james> |
Component: | Core | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
Status: | CLOSED WONTFIX | ||
Severity: | enhancement | CC: | gormer, pixelcort, rooneg |
Priority: | P3 | Keywords: | PatchAvailable, RFC |
Version: | 2.0-HEAD | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | updated patch, correcting issues I noticed from the proposed patch |
Description
James E. Robinson, III
2004-09-14 22:01:32 UTC
I'm not sure, as I'm not familiar with this code, but at first glance this patch seems incomplete. I think if you add entries to the status_lines array you also need to bump up the RESPONSE_CODES define in httpd.h. Additionally, all the other spots in the array that have gaps in the numbers insert "unused" slots, so this probably has to do the same thing. Finally, the addition of an entry in the 200 section will invalidate the LEVEL_300, LEVEL_400, and LEVEL_500 defines, so those will have to be adjusted to account for the new slots being used. Created attachment 12746 [details]
updated patch, correcting issues I noticed from the proposed patch
fixed in 2.1.3 per veto from roy, this change was backed out of 2.1.3. please see the discussion thread at http://marc.theaimsgroup.com/?t=110260191100002&r=1&w=2 for more details. |