|Summary:||[PATCH] Fix for HSSF Bug #33160|
|Product:||POI||Reporter:||Amol Deshmukh <amolweb>|
|Component:||HSSF||Assignee:||POI Developers List <dev>|
[PATCH] Patch file for bug 33160
Patch updated with test case
Description Amol Deshmukh 2005-02-02 23:08:10 UTC
Setting value of cell to formulas containing numbers greater than Short.MAX_VALUE (Java) caused an exception. This was due to a bug in the FormulaParser class. The code had a TODO comment saying something to the effect that numbers greater than Short.MAX_VALUE would cause a problem. The patch modifies the code so that a check is made to see if the number is larger than Short.MAX_VALUE and accordingly either IntPtg or NumberPtg is used in FormulaParser. The patch also includes an additional test case (method added to class TestFormulaParser that checks the behaviour of HSSF for large values in cell formulas).
Comment 1 Amol Deshmukh 2005-02-02 23:09:14 UTC
Created attachment 14163 [details] [PATCH] Patch file for bug 33160 Patch for 33160. See previous comment for details.
Comment 2 Avik Sengupta 2005-04-21 14:20:23 UTC
This patch seems to be the same as the one attached to bug 33160. Amol, is this what you intened? Pls Clarify!
Comment 3 Amol Deshmukh 2005-04-21 14:26:36 UTC
(In reply to comment #2) > This patch seems to be the same as the one attached to bug 33160. Amol, is this > what you intened? Pls Clarify! Apologize for the confusion. I attached the patch to the bug 33160 prior to attaching here, but later I came across some patch submission FAQ that said patches should be filed and submitted as a separate entry in bugzilla. Hence the duplication of this patch. The patch is IDENTICAL to the one submitted for 33160.
Comment 4 Avik Sengupta 2005-04-21 14:31:40 UTC
I am sorry if the documentation confused you... If a bug is already open, the patch is best attached to the same bug. But no probs. Btw, I dont see a test method in the patch? The patch only contains a diff for FormulaParser..?
Comment 5 Amol Deshmukh 2005-04-21 14:56:18 UTC
Created attachment 14773 [details] Patch updated with test case This patch code is similar to the earlier, with one update but it also has the test case.