| Summary: | Port lost after call to "internal_internal_redirect" in "modules/http/http_request.c" | ||
|---|---|---|---|
| Product: | Apache httpd-2 | Reporter: | Jonas Ringh <jonas.ringh> |
| Component: | Core | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | m.stoff |
| Priority: | P2 | Keywords: | FixedInTrunk, PatchAvailable |
| Version: | 2.2.6 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: | Patch that fixes the problem | ||
Created attachment 15865 [details]
Patch that fixes the problem
This bug is still present in 2.2.6 This bug is still present in 2.2.9 on Windows (not tried on other platforms, but I assume there as well). Oops, this has languished a long time. Fixed in Trunk in r807015 - thanks for the report and patch. |
When using "internal_internal_redirect" the server port the request was made though is lost. As far as I can tell this is only an issue if you are using a port that differs from the default one. Here is one way to reproduce the bug using the rewrite engine... 1. Setup a virtual server to use at least two ports. --- --- --- Listen 80 Listen 81 NameVirtualHost x.x.x.x:80 NameVirtualHost x.x.x.x:81 <VirtualHost x.x.x.x:80 x.x.x.x:81> DocumentRoot /home/user/bugtest_web </VirtualHost> --- --- --- 2. In the root directory of the server, create a test script that prints the "SERVER_PORT" environment variable. Could for instance be a CGI-script, in which case you also need to enable ExecCGI for the directory containing the test script. --- --- --- #!/bin/sh echo Content-type: text/plain echo echo SERVER_PORT = $SERVER_PORT --- --- --- 3. Within a "<directory>" directive create a rewrite rule that makes a local redirect to the test script. --- --- --- <directory /home/user/bugtest_web> RewriteEngine on RewriteRule test test.cgi </directory> --- --- --- 4. Navigate to the test file via the rewriterule on both ports... $ lynx -dump x.x.x.x:80/test $ lynx -dump x.x.x.x:81/test In both cases the output will be... SERVER_PORT = 80 The port that comes first in the virtualhost declaration is the one that is returned. The port that corresponds to the request is obviously what should be returned. After sifting though the source I found that mod_rewrite uses "ap_internal_redirect" to do the actual redirect. "ap_internal_redirect" calls "internal_internal_redirect" to setup the "request_rec" for the new URI. While doing that the original port information associated with the request is not copied to the new URI.