Bug 40057

Created attachment 18610 [details]
patch for TxMasterStyleAtom

TxMasterStyleAtom stores default (master) character and paragraph styles. 

The doc describing the record structure is to be written. 
As always documenting is the hardest and the most tedious job. :))

Thanks for this, committed

Are the list of TextProp's pretty much the same for StyleTextPropAtom and
TxMasterStyleAtom?

If so, it might be good to keep the list together?

>Are the list of TextProp's pretty much the same for StyleTextPropAtom
>and TxMasterStyleAtom?

The list of properties for TxMasterStyleAtom is very close to what we have for 
StyleTextPropAtom
BUT the bitmasks for the same property can be different.
Example:
  in StyleTextPropAtom font.size is 0x20000
  in TxMasterStyleAtom font.size is 0x80000

It was the hardest part to understand it. I spent a lot of time trying to create
a generic list of properties
which works in both cases. No luck, They are just different!
Looks like in Microsoft TxMasterStyleAtom and StyleTextPropAtom were implemented
by different developers
and they didn't communicate with each other.

>If so, it might be good to keep the list together?
I think we need to move  TextPropCollection out of
StyleTextPropAtom and keep all the stuff in it. What do you think?


Regards,
Yegor

I'm happy to move TextProp/TextPropCollection out, now it's used in two places.
I think it probably still belongs in the record heirachy though.

I guess we should probably keep the lists of TextProps in StyleTextPropAtom /
TxMasterStyleAtom though. It's crazy that they're different....

I'm resolving it.

TxMasterStyleAtom is implememented. 
There will be some refactoring after 3.0 release but that's another story.

Yegor