Summary: | Poor error msg when using errorReportValveClass in Host element | ||
---|---|---|---|
Product: | Tomcat 5 | Reporter: | Veit Guna <grave> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 5.0.20 | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | other | ||
Attachments: | Patch to add stracktrace to logging |
Description
Veit Guna
2006-11-22 11:19:56 UTC
Please update the documentation. --snip-- if(!found) { Valve valve = (Valve) Class.forName(errorReportValveClass) .newInstance(); addValve(valve); errorReportValveObjectName = ((ValveBase)valve).getObjectName() ; --snip-- It seems that one has to extend ValveBase - not just implemented the Valve interface. Created attachment 19162 [details]
Patch to add stracktrace to logging
This will add the stacktrace to the logger when an error occurs while setting
the errorReportValveClass on Host configuration.
The patch is against the 5.5.20 version. The log message patch has been applied to SVN. Rather than amend the docs, I rewrote the code to remove the requirement to extend ValveBase. This fix will be in 5.5.21 onwards. |