Summary: | ImageProvider should be overridable in ImageFactory | ||
---|---|---|---|
Product: | Fop - Now in Jira | Reporter: | Torok Edwin <edwin.torok> |
Component: | images | Assignee: | fop-dev |
Status: | NEW --- | ||
Severity: | normal | ||
Priority: | P3 | ||
Version: | 0.93 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | other | ||
Attachments: |
Use JAI ImageIO as default
tiff images to reproduce bug |
Description
Torok Edwin
2007-02-21 02:32:59 UTC
Created attachment 19617 [details]
Use JAI ImageIO as default
I have temporarely used this patch to use JAI ImageIO by default.
Of course this assumes you have jai_imageio.jar on classpath, and fails
otherwise.
A better solution could be to use jai_imageio/jai only if the jar is available
on classpath. IOW if an imageprovider can't deal with an image, use the next
one in the list.
Currently if ImageIO is the first one, and you don't have jai_imageio
available, the loading of fop's ImageIO wrapper succeeds, but
FopImage.loadDimensions() fails.
Hmm, TIFFs with Group 4 compression are supposed to work. Any chance you could attach/send the TIFF so I can take a look when I've got time? BTW, it is planned to redesign the whole image package. This will improve the situation a lot and I plan to add facilities to make the image providers easily configurable. Created attachment 19632 [details]
tiff images to reproduce bug
I can't send you the original pictures due to copyright issues.
However we have discovered what is different on tiffs that don't work, and have
created 2 sample tiffs for you: 001.tif works with fop, 002.tif doesn't work
with fop.
I have used fop-0.93, and created works/notworks.pdf like this:
edwin@edwin-t-new:~/fopp$ sh ./fop works.fo -pdf works.pdf
edwin@edwin-t-new:~/fopp$ sh ./fop notworks.fo -pdf notworks.pdf
Open notworks.pdf, and compare it with works.pdf.
Images 001.tif and 002.tif are the same, except for the pixel aspect ratio.
The problem is with pixel aspect ratio. When pixel aspect ratio is square, fop
handles the image correctly. When pixel aspect ratio is custom (like for fax
images), fop doesn't handle the image correctly. The pixel aspect ratio should
be square for proper viewing.
[You can see/change the pixel aspect ratio of a tiff in Photoshop (image->pixel
aspect ratio)]
I've got another set of files to reproduce this bug with fop-0.93. Using the external-graphic tag, the bug occurs with a multi-strip tiff (group 4 compression). A single-strip copy of the image works. Both files are single-page tiffs and otherwise identical. Should I attach my files? (A4 pages, ~ 260 KB zip with the PDFs) resetting P2 open bugs to P3 pending further review |