|Product:||Apache httpd-2||Reporter:||rahul <rahul.g.nair>|
|Component:||mod_proxy||Assignee:||Apache HTTPD Bugs Mailing List <bugs>|
mod_proxy_ftp.c refactoring patch (removes redundant functions)
Description rahul 2007-02-22 01:06:18 UTC
Refactoring mod_proxy_ftp to do these: 1) organize the heavy mod_proxy_ftp_handler to be similar to mod_proxy_http (use the same functions as the mod_proxy_http where possible) 2) Split the mod_proxy_ftp_handler to smaller functions organized as a state machine so that the code flow is easier to follow 3) Avoid the network traffic to ftpserver where possible (and instead Intelligently guess the required values.)
Comment 1 rahul 2007-02-22 01:09:17 UTC
Created attachment 19624 [details] mod_proxy_ftp.c diff The patch contains refactored mod_proxy_ftp.c diffed against 2.3 trunk
Comment 2 Ruediger Pluem 2007-02-22 14:22:32 UTC
Thanks for the patch. It is rather huge and thus hard to review. In order to get it applied please use the following procedure: 1. Split the patch in smaller more consumable chunks (at least into three chunks that address each of the 3 issues you try to solve separately). 2. Attach the patches here and post them to firstname.lastname@example.org to draw developer attention to them and to have a discussion about them. 3. Be PPP (patient, persistent and polite) :-) here and on dev@. As people are usually very busy smaller and easier patches increase the likelihood that someone finds time to review them. Furthermore sometimes people (including me :-)) just forget about cool patches because they were not able to handle them immediately, so a gentle ping sometimes helps to bring this back on the agenda.
Comment 3 rahul 2007-08-23 07:58:03 UTC
Created attachment 20692 [details] mod_proxy_ftp.c refactoring patch (removes redundant functions) This is a patch to do: - organize the heavy mod_proxy_ftp_handler to be similar to mod_proxy_http (use the same functions as the mod_proxy_http where possible) The proxy_ftp_handler has been modeled after proxy_http_handler, and uses the same functions that is used in that. This allows us to remove the portion that does - acquire-connection, determine-connection, connect-backend and connection-create. A new function ap_proxy_ftp_request is added which implements the exclusively ftp logic. This function contains the rest of proxy_ftp_handler code.
Comment 4 Rainer Jung 2018-02-25 20:56:40 UTC
Undo spam change