Summary: | Better exception for PowerPoint documents from unsupported versions | ||
---|---|---|---|
Product: | POI | Reporter: | Trejkaz (pen name) <trejkaz> |
Component: | HSLF | Assignee: | POI Developers List <dev> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | 3.0-dev | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | other | ||
Attachments: | Example PowerPoint 95 document |
Description
Trejkaz (pen name)
2007-02-26 19:12:59 UTC
I think we should only through something like WrongPowerPointVersionException if we can detect that. Most of the cases I've seen with broken CurrentUserAtoms really have been corrupt files. If you can upload a sample file from an older version of PPT with a short CurrentUserAtom, I'll look at detecting that and returning a more useful exception. The way we currently detect if the PowerPoint document is of the form HSLF supports, is to open the CurrentUserAtom and look for the magic number. If it isn't there, then we consider that it isn't of the right version, and so far that's been good enough since Office was able to open the remaining ones. Created attachment 19655 [details]
Example PowerPoint 95 document
I've added OldPowerPointFormatException, which CurrentUserAtom will now throw if it detects a ppt95 file Noting that this works for our test data, including all the ones we didn't attach. |