Summary: | Let HTTP Proxy handle encoding of request, and undecode parameter values | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Alf Hogemark <alf> |
Component: | HTTP | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | 2.2 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Suggested patch
Updated suggested patch |
Description
Alf Hogemark
2007-04-19 06:55:56 UTC
Created attachment 20003 [details]
Suggested patch
This suggested patch adds two maps to the proxy Deamon class, so that the proxy
server can keep the page and form encodings it finds in a request, so it can be
used in requests the proxy will see in the future. The access to these two maps
are synchronized, since the deamon kicks off a Proxy on a separate thread for
each incoming request.
The patch makes the HttpRequestHdr uses the encoding for the request / page /
form, and then decodes the request body using that encoding, and then adds
parameters undecoded where appriopriate to the sampler.
Tried applying the patch, and it causes serveral NPEs and some other test failures... (In reply to comment #2) > Tried applying the patch, and it causes serveral NPEs and some other test > failures... Thanks for the comments. I will look into improving this patch. And I will try to convince myself that this patch is really needed, I am currently a bit skeptical if the functionality we gain is worth the extra complexity of the code. Created attachment 20160 [details]
Updated suggested patch
Patch is now updated, fixed a couple of bugs, which caused unit tests to fail.
The patch is needed to support posting of forms with encoding UTF-8, when
entering UTF-8 characters. Without this patch, you see only garbage in the test
plan, and the data recieved from browser is then sent garbled from proxy to web
server.
The patch is nice to have, in that you get the values unencoded into the test
plan, so it is easier to read for the test plan user.
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/1915 |