| Summary: | [PATCH] Allow usage of lenya properties in notifier.xconf | ||
|---|---|---|---|
| Product: | Lenya | Reporter: | Markus Angst <mangst> |
| Component: | Miscellaneous | Assignee: | Lenya Developers <dev> |
| Status: | NEW --- | ||
| Severity: | enhancement | ||
| Priority: | P2 | ||
| Version: | Trunk | ||
| Target Milestone: | 2.0.1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Patch for enhancement described above | ||
Created attachment 20557 [details]
Patch for enhancement described above
what about this patch? is it already being dealt with? the feature makes sense imho, so it would be nice to have it in before 2.0. it's nicely self-contained, seems to be low risk. i'd commit it, only i don't have a setup for testing it properly. anyone? jragaller? The question remains if there is a more generalized approach for this kind of feature that covers more (or all) modules and their xconf files; at least the ones that contain deployment specific parameters. One more example would be defining JDBC datasources in cocoon.xconf. Maybe there is a mechanism in Cocoon already that i overlooked? |
This patch allows the usage of lenya properties in attributes of the smtp node of notifier.xconf: <smtp host="${smtphost}" username="${username}" password="${password}" /> This file is used by the EmailNotifier. Properties are resolved from all property files that are handled by PropertiesModule (lenya.properties.xml). This way you don't have to patch these values in cocoon.xconf during deployment anymore. This patch is meant to be a proposal. It works for me, but there might most likely exist better implementations; especially concerning the avalon stuff, about which I don't have a clue :-). Or maybe this can be generalized to work with other modules (like contactform), too...