Summary: | mod_jk memory leak when apache graceful restart | ||
---|---|---|---|
Product: | Tomcat Connectors | Reporter: | Eiji Takahashi <mashmk02> |
Component: | Common | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | Linux |
Description
Eiji Takahashi
2007-11-15 07:18:33 UTC
Huh, You are correct. The complete log_fmt_subsec is a complete mess. It's either assigned as const char* or allocated. Even more it's wrongly used later, presumed as JK_TIME_MAX_SIZE long, but actually JK_TIME_MAX_SIZE + strlen(JK_TIME_PATTERN_MICRO) Thanks for reporting. The leak has been fixed in r596746 (in a slightly different way, because I don't want to expose the internals of timestamp formatting to the web server). Mladens comments about the complicated size handling led to another revision r596747. Even without r596747 there was no buffer overflow issue, because the longer string was truncated with '\0' before it was used in the shorter context. The changes will be part of version 1.2.26, which we expect to release soon. There will be a testing tarball before, with an announcement via the dev list. |