| Summary: | javax.servlet.jsp.jstl.sql.ResultSupport.java silently swallows SQLException | ||
|---|---|---|---|
| Product: | Taglibs | Reporter: | Biswadeep Chowdhury <cbiswa> |
| Component: | Standard Taglib | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | ||
| Priority: | P1 | ||
| Version: | 1.1 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
*grumble* Easiest fix - throw SQLException from those methods. Can't - it's in the spec. Plus it would be a bit of a back compat surprise. Next - create a new file - can't this is spec land. Next - use src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java directly rather than ResultSupport. Of course - that means people aren't using the spec anymore even if it is the same class (or copy of that class). Still - worth doing I think, so I've made that commit. Next is your RuntimeException, but that's another back compat surprise for people. Here's my change: svn ci -m "Adding constructors to ResultImpl to work around the SQLException hiding in ResultSupport - and noted this in ResultSupport as per #46086" src Sending src/javax/servlet/jsp/jstl/sql/ResultSupport.java Sending src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java Transmitting file data .. Committed revision 711123. |
Please replace the catch clause in javax.servlet.jsp.jstl.sql.ResultSupport.java methods to throw a wrapped RuntimeException instead of silently swallowing SQLException. Replace: } catch (SQLException ex) { return null; } By something like the following: } catch (SQLException ex) { throw new RuntimeException(ex); }