Bug 46580

Summary: NotImplementedFunction should throw an exception instead of silent internal errors
Product: POI Reporter: Josh Micich <josh>
Component: HSSFAssignee: POI Developers List <dev>
Status: RESOLVED FIXED    
Severity: normal    
Priority: P2    
Version: 3.0-FINAL   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   

Description Josh Micich 2009-01-21 18:00:12 UTC
This change was motivated by these threads:
http://mail-archives.apache.org/mod_mbox/poi-user/200901.mbox/%3Ca644352c0901131503q44ce53a0ld9e225bbe0419642@mail.gmail.com%3E

http://mail-archives.apache.org/mod_mbox/poi-user/200901.mbox/%3C4551EAB41622EC4AA6CFAAB005485C01D533FD@SFPWMF107.polk.com%3E

When the evaluator comes across an unimplemented function, an internal error code was returned.  This value is not suitable for writing into a FormulaRecord or BoolErrRecord, because it causes errors when opening the file in Excel.
Comment 1 Josh Micich 2009-01-21 18:00:34 UTC
The fix is to remove ErrorEval.FUNCTION_NOT_IMPLEMENTED change all methods that returned that value to throw NotImplementedException instead.

Applied in svn r736505