Summary: | Remaining functionality for Sheet.shiftRows() | ||
---|---|---|---|
Product: | POI | Reporter: | Josh Micich <josh> |
Component: | HSSF | Assignee: | POI Developers List <dev> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | onealj, yegor |
Priority: | P5 | Keywords: | PatchAvailable |
Version: | 3.5-dev | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 54533, 52903, 56454, 56497, 58557 | ||
Bug Blocks: | |||
Attachments: | Proposed patch for hyperlink shift |
Description
Josh Micich
2009-02-19 19:36:12 UTC
I would add these (in priority order): - Repeating rows and columns (workbook.setRepeatingRowsAndColumns ) - Hyperlinks attached to cells - Anchors of drawings (needed?) - pictures and shapes anchored to cells - drop-down lists with the data set as cell area reference - pivot areas ( we should at least check that shiftRows doesn't break .xls with pivot areas) - Excel charts (I'm not sure what this involves) shiftRows is getting complicated. It includes more functionality than a single method can fit. It may be worth putting the logic in a class and use in HSSF-XSSF, or make this class abstract and have HSSF and XSSF implement a method per each operation. All common functionality should be tested in terms of common org.apache.poi.ss.usermodel.* interfaces. This should be true for common HSSF-XSSF tests in general, not only for shiftRows. There is an attempt to do that in org.apache.poi.ss.usermodel.BaseTestSheetShiftRows and I expect that we will follow this approach. As to priorities, I agree that the highest one is Defined names. Without it shiftRows does not guarantee the consistence of sheet formulas. The other items can be shuffled. XSSF does not yet support Conditional formats and Data validations and I doubt it will be included in 3.5-final. Also, XSSF does not yet process VB/Form formulas. My adjusted list: - Defined names (XSSF and HSSF) - Conditional formats (HSSF) - Data validations (HSSF) - Print Areas (XSSF and HSSF) - Repeated Rows / Columns (XSSF and HSSF) - Page Breaks (XSSF and HSSF) - Cell Comments (XSSF and HSSF) - Hyperlinks (XSSF and HSSF) - Row Groupings (XSSF and HSSF) - VB/Form object formula properties (HSSF) - Active/selected cells (XSSF and HSSF) Yegor I added support for shifting named ranges both for HSSF and XSSF. With FormulaShifter it was really easy, just a few lines of code. Yegor Created attachment 31626 [details]
Proposed patch for hyperlink shift
Here is a patch proposal to support hyperlink shift.
It is based on POI 3.10 and it works only for XSSF
(In reply to Alessandro Guarascio from comment #3) > Created attachment 31626 [details] > Proposed patch for hyperlink shift > > Here is a patch proposal to support hyperlink shift. > It is based on POI 3.10 and it works only for XSSF To keep this organized, I've moved XSSF hyperlink shifting to bug 58557 and made it a blocker of this bug. |