Summary: | HttpServletRequest.getAttributeNames() does not return the names of all attributes | ||
---|---|---|---|
Product: | Tomcat 6 | Reporter: | Chris Markle <cmarkle> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 6.0.20 | ||
Target Milestone: | default | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Attachments: |
Original email exchange on this issue
Patch that adds internal attributes but breaks TCK tests |
Description
Chris Markle
2009-06-12 13:44:21 UTC
Created attachment 23806 [details]
Original email exchange on this issue
Created attachment 24451 [details]
Patch that adds internal attributes but breaks TCK tests
I looked at just including all the Tomcat internal attributes in the return from getAttributeNames() but this causes problems with the Servlet 2.5 TCK tests which expect that getAttributeNames() return only those attributes that have been set via setAttribute().
Therefore it looks like the doc change is the way I'll have to go. For completeness the patch I tried that returned all the attribute names is attached so you can patch Tomcat locally if you particularly need that functionality. I thought about making this a configurable option but I didn't want to add the complexity for something that I couldn't see causing any problems that can't be easily worked around by an app that needed to.
Trunk and 6.0.x now have updated Javadoc. Thsi will be included in 6.0.21 onwards. |