Summary: | NamingContextListener fails to add itself as a PropertyChangeListener to all namingResources | ||
---|---|---|---|
Product: | Tomcat 5 | Reporter: | Michael Allman <msa> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | msa |
Priority: | P2 | ||
Version: | 5.5.28 | ||
Target Milestone: | --- | ||
Hardware: | Macintosh | ||
OS: | Mac OS X 10.4 | ||
Attachments: | proposed fix |
I just want to add that without this patch, the standard Admin app functionality of adding a DataSource to a deployed Web app does not work. (Adding a DataSource dynamically is my app's use case as well, incidentally.) Thanks for the patch. It has been applied to trunk and proposed for 6.0.x and 5.5.x This has been fixed in 6.0.x and will be included in 6.0.21 onwards. Thanks again for the patch. Can this please be applied to 5.5.x and released with 5.5.29? I ask because my client is using a patched (with this patch) version of 5.5.28 in production and I'd like to simplify their upgrades by obviating the need to patch and build future releases of 5.5.x. Thanks. The patch has been applied to 5.5.x and will be included in 5.5.29 onwards. Again, thanks for the patch. |
Created attachment 24378 [details] proposed fix In the NamingContextListener.lifecycleEvent(LifecycleEvent) method, the NamingContextListener object fails to add itself as a PropertyChangeListener to namingResources whose context is not a Server, e.g. a Context instance. This prevents the NamingResourcesMBean from working with non-Server contexts.