Summary: | Multiple problems / enhancements with JMS protocol classes. | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | martinrl <martinrleon> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | P2 | ||
Version: | 2.3.4 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Mac OS X 10.4 | ||
Attachments: |
Proposed patches
Patches with original source Proposed patches Proposed patches against current revision |
Description
martinrl
2009-11-06 11:35:47 UTC
Created attachment 24503 [details]
Proposed patches
Thanks for the suggestions. Unfortunately they cannot be applied as they stand, as the source code has changed, and the changes are provided as full source files which no longer provide sensible differences. Please can you provide the changes as patches in unified difference format? Ideally against the current version in SVN, but even differences from the source you based your changes on would probably be OK. I'm a newbie to submitting patch suggestions. I am attaching a ZIP file with the original and fixed files in separate folders. If you need me to do more, please let me know. I want to contribute in whatever way I can. Thank you for such a great tool! I am still learning it, but I see it as a very valuable tool, thank you very much! Created attachment 24531 [details]
Patches with original source
I re-read your response, what is a "unified different format"? Can you point me to a URL explaining how to do this? The files I provided can be "diff"d against each other. They are the original 2.3.4 source and the fixed source files. Please let me know if you want me to do something different. (In reply to comment #5) > I re-read your response, what is a "unified different format"? Can you point > me to a URL explaining how to do this? http://www.apache.org/dev/contributors.html#patches Created attachment 24532 [details]
Proposed patches
Thanks for guide on patches. Here's the resulting patch file.
(In reply to comment #7) > Created an attachment (id=24532) [details] > Proposed patches > > Thanks for guide on patches. Here's the resulting patch file. Unfortunately the patch appears to have been made by comparing your version against the current code in trunk. As your changes were not made to the current code, this means that several recent changes would be lost if the patches were applied. What's needed is a patch file showing exactly what you changed, i.e. the changes need to be against whatever you started with, which I think was 2.3.4? Alternatively, redo your changes to the current code in trunk, and produce a new patch for that. Created attachment 24538 [details]
Proposed patches against current revision
One more time.... Thanks for your patience with a rookie!
Is there anything else I need to do to get this patch to be in an acceptable format? (In reply to comment #8) > (In reply to comment #7) > > Created an attachment (id=24532) [details] [details] > > Proposed patches > > > > Thanks for guide on patches. Here's the resulting patch file. > > Unfortunately the patch appears to have been made by comparing your version > against the current code in trunk. As your changes were not made to the current > code, this means that several recent changes would be lost if the patches were > applied. > > What's needed is a patch file showing exactly what you changed, i.e. the > changes need to be against whatever you started with, which I think was 2.3.4? > > Alternatively, redo your changes to the current code in trunk, and produce a > new patch for that. The patch is a lot better, but still makes some unnecessary changes, for example: - private final TopicConnection CONN; + private TopicConnection CONN = null; and related changes in the static {} block. It's important that the variable (and others like it) remains final, otherwise it may not be published correctly across threads. However, I think I can work round those changes; the other changes look OK. Applied to SVN: URL: http://svn.apache.org/viewvc?rev=889456&view=rev Log: Bug 48155 - Multiple problems / enhancements with JMS protocol classes I made one or two other changes, for example responseCode should be "200" for OK, not a text message. The code will be in nightly builds after r889456 - please re-open the bug if there are any problems. My first open source bug patch! Woohoo! Thanks for the free lessons. Hopefully I'll be able to contribute more in the future. (In reply to comment #12) > Applied to SVN: > > URL: http://svn.apache.org/viewvc?rev=889456&view=rev > Log: > Bug 48155 - Multiple problems / enhancements with JMS protocol classes > > I made one or two other changes, for example responseCode should be "200" for > OK, not a text message. > > The code will be in nightly builds after r889456 - please re-open the bug if > there are any problems. This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2309 |