Bug 48343

Summary: [PATCH] SUBTOTAL function
Product: POI Reporter: Paul Tomlin <pault>
Component: HSSFAssignee: POI Developers List <dev>
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X 10.4   
Attachments: Implementation of SUBTOTAL + FunctionEval change

Description Paul Tomlin 2009-12-06 23:50:56 UTC
Created attachment 24673 [details]
Implementation of SUBTOTAL + FunctionEval change

A patch for a very simple implementation of the SUBTOTAL function.

This works for the unit tests I have for an internal project processing 3rd party Excel spreadsheets though at this point I have no POI specific tests.

The specific formulas curently tested are SUBTOTAL(9, <AREA>)

http://poi.apache.org/spreadsheet/eval-devguide.html seems to be out of date, I can find no GenericFormulaTestCase class.

Comments on the strategy used in the patch and current test writing outline would be appreciated.
Comment 1 Paul Tomlin 2009-12-07 03:06:51 UTC
Created attachment 24675 [details]

manual tests mimicking existing tests in the same package
Comment 2 Josh Micich 2009-12-08 09:45:22 UTC
Applied in svn r888490

Thanks for the patch.  I made slight tweaks and added some javadoc.  Please reply if the changes are NQR.

The unit test you supplied looked fine.  It shows well the coverage of supported functionality.