| Summary: | Lock fields should be final | ||
|---|---|---|---|
| Product: | Tomcat 6 | Reporter: | Sebb <sebb> |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | default | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Attachments: |
Patch to make lock fields final
Patch fields that should be final |
||
Created attachment 24717 [details]
Patch fields that should be final
Found more locks; fields could probably also be made private
The patches already been applied to trunk. I have proposed them for 6.0.x. This has been fixed in 6.0.x and will be included in 6.0.23 onwards. |
Created attachment 24714 [details] Patch to make lock fields final A field that is used as a lock should be final. The following classes have mutable locks: org.apache.jasper.compiler.AntCompiler.javacLock org.apache.catalina.ha.session.DeltaSession.diffLock