|Summary:||Lock fields should be final|
|Product:||Tomcat 6||Reporter:||Sebb <sebb>|
|Component:||Catalina||Assignee:||Tomcat Developers Mailing List <dev>|
Patch to make lock fields final
Patch fields that should be final
Description Sebb 2009-12-16 19:14:51 UTC
Created attachment 24714 [details] Patch to make lock fields final A field that is used as a lock should be final. The following classes have mutable locks: org.apache.jasper.compiler.AntCompiler.javacLock org.apache.catalina.ha.session.DeltaSession.diffLock
Comment 1 Sebb 2009-12-16 19:40:25 UTC
Created attachment 24717 [details] Patch fields that should be final Found more locks; fields could probably also be made private
Comment 2 Mark Thomas 2009-12-30 03:15:00 UTC
The patches already been applied to trunk. I have proposed them for 6.0.x.
Comment 3 Mark Thomas 2010-01-06 02:51:53 UTC
This has been fixed in 6.0.x and will be included in 6.0.23 onwards.