Bug 48747

Summary: TCP Sampler swallows exception samples
Product: JMeter Reporter: Andrey Pohilko <apc>
Component: MainAssignee: JMeter issues mailing list <issues>
Status: RESOLVED FIXED    
Severity: normal    
Priority: P2    
Version: 2.3.4   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Attachments: Here's proposed changes to source code to fix the issue

Description Andrey Pohilko 2010-02-16 08:12:58 UTC
When exception occurs during sample in TCP sampler, such samples won't appear in results and will be hidden. This may affect test consistency.

Eg if we use BinaryTCPClientImpl class and passing uneven hex data (000), an exception will be thrown by BinaryTCPClientImpl but not caught by TCPSampler.

I suggest to add handling such exceptions by TCPSampler, keep logging and generate failed sample.
Comment 1 Andrey Pohilko 2010-02-16 08:17:25 UTC
Created attachment 24994 [details]
Here's proposed changes to source code to fix the issue

By the way I want to check if diff file format is correct and I may send larger patches in this format.
Comment 2 Sebb 2010-02-16 15:22:23 UTC
Thanks, that patch applied perfectly:

URL: http://svn.apache.org/viewvc?rev=910559&view=rev
Log:
Bug 48747 - TCP Sampler swallows exceptions

Modified:
   jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
   jakarta/jmeter/trunk/xdocs/changes.xml