| Summary: | org.apache.catalina.connector.Request clone static SimpleDateFormat | ||
|---|---|---|---|
| Product: | Tomcat 6 | Reporter: | Ondrej Medek <xmedeko> |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | default | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: |
Test performance creation of the Request() object
Requested changes added to the Request Class |
||
Created attachment 25317 [details]
Test performance creation of the Request() object
Created attachment 25318 [details]
Requested changes added to the Request Class
On my machine I saw an increase in roughly 12% of performance.
Thanks for the patch. Because Request objects are recycled this improvement will only apply on the creation of a Request object and even then the performance improvement is in the order of microseconds. The patch has been applied to 9.0.x for 9.0.0.M5 onwards. |
Faster usage of the thread unsafe SimpleDateFormat is: private static final SimpleDateFormat FORMAT_PROTOTYPE = new SimpleDateFormat("...", Locale.ROOT); static { format.setTimeZone(GMT_ZONE); } protected SimpleDateFormat format = (SimpleDateFormat)FORMAT_PROTOTYPE.clone(); Please, apply this pattern to the formats[] field. It shoudl speed up the request processing a little bit. Thanks