| Summary: | Enhance RemoteIpValve and RemoteIpFilter logging | ||
|---|---|---|---|
| Product: | Tomcat 6 | Reporter: | Cyrille Le Clerc <cleclerc> |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 6.0.26 | ||
| Target Milestone: | default | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: |
RemoteIpFilter logging enhancement
RemoteIpValve logging enhancement |
||
Created attachment 25181 [details]
RemoteIpValve logging enhancement
Thanks for the patches. They have been applied to trunk and will be included in 7.0.0 onwards. I have proposed for valve patch for 6.0.x The patch has been applied to 6.0.x and will be included in 6.0.27 onwards. Thanks again for all your work in this area. |
Created attachment 25180 [details] RemoteIpFilter logging enhancement RemoteIpValve and RemoteIpFilter logging can be enhanced to ease understanding why a remote address is not seen as one of the internal proxies ip list. This is particularly useful to troubleshoot unexpected usage of IP-V6 when IP-V4 is expected. Patch is provided in two separated files to ease merge of the RemoteIpValve patch to Tomcat 6.0.x branch. Added log messages : RemoteIpFilter.java : "Skip RemoteIpFilter for request " + request.getRequestURI() + " with originalRemoteAddr '" + request.getRemoteAddr() + "'" RemoteIpValve.java : "Skip RemoteIpValve for request " + request.getRequestURI() + " with originalRemoteAddr '" + request.getRemoteAddr() + "'"