Summary: | Build fails on Linux when skip.installer set to true | ||
---|---|---|---|
Product: | Tomcat 5 | Reporter: | Henri Yandell <hyandell> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 5.5.28 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: |
Alternative patch
2010-06-07_tc55_bug48990.patch |
Description
Henri Yandell
2010-03-25 21:26:43 UTC
Looks like your build environment is not set up correctly. Both the current and the previous Tomcat 6 build managers use Linux to build the releases. Reopening with better description of how to recreate the issue. I've updated the subject to better fit the issue, namely failure to build when skipping the installer. Steps: Download source. Unpack. Modify build.properties to change where downloads go. Modify build.properties to set skip.installer to true (otherwise there is a wine error). `ant download` `ant` `ant -f extras.xml` `ant -f dist.xml` Error: apache-tomcat-6.0.26-src/dist.xml:454: /home/hyandell/apps/apache-tomcat-6.0.26-src/output/dist/bin/x64 not found. Noting that this is not a problem with 7.0 from trunk. Previous problems are with the official src.tar.gz downloads for 5.5.x and 6.0.x. Created attachment 25477 [details]
Alternative patch
skip.installer should do just that. No need to skip the .zip distros.
Alternative patch proposed for 6.0.x With your patch (applied to 6.0.26), I get an error that it can't find the commons-daemon-1.0.1/windows/prunsrv.exe file to copy. Looking at the unpacked commons-daemon-1.0.1 from http://archive.apache.org/dist/commons/daemon/binaries/commons-daemon-1.0.1.tar.gz, I don't see a windows directory there. That would be because the build uses commons daemon 1.0.2 Gotya. I'm still on 6.0.26 with 1.0.1, but the patch looks good from visual inspection. Fixed in 6.0.x and will be in 6.0.27 onwards Created attachment 25537 [details] 2010-06-07_tc55_bug48990.patch Looking at comment #3 and how the build file is implemented, it looks that it is a problem for 5.5 as well. I am attaching patch that fixes this issue in Tomcat 5.5 (backport of r952023) AND introduces support for "skip.installer" property. Defining the "skip.installer" property will allow to skip creating the installer when running Tomcat 5.5 build on Windows. Testing with just "skip.installer" part of the above tc5.5 patch, I should say that I do not see any build failures.
I.e., the Unix builds of 5.5.28 should build successfully. The only thing is that zip/tar.gz files created by such build will differ with the ones created on Windows in that they do not include the following files and folders:
bin/tomcat5.exe
bin/tomcat5w.exe
bin/tcnative-1.dll
bin/i64/
bin/i64/tomcat5.exe
bin/i64/tcnative-1.dll
bin/x64/
bin/x64/tomcat5.exe
bin/x64/tcnative-1.dll
The effect of the above tc5.5 patch (attachment 25537 [details]) is that
A) it will align zip/tar.gz files created by building a release on Unix with the ones on Windows.
The ones on Unix will not omit the above said exe/dll files.
B) it will provide support for "skip.installer" property
Reopening, changing Product, Version to track it in Tomcat 5.5.
The patch was proposed for 5.5. This has been fixed in 5.5.x and will be included in 5.5.30 onwards. |