Summary: | [PATCH] Inefficient concatenation of ContinueRecord contents in AbstractEscherHolderRecord | ||
---|---|---|---|
Product: | POI | Reporter: | Trejkaz (pen name) <trejkaz> |
Component: | HSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | major | Keywords: | PatchAvailable |
Priority: | P2 | ||
Version: | 3.5-FINAL | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Proposed patch
Proposed patch |
Description
Trejkaz (pen name)
2010-04-06 03:49:05 UTC
Created attachment 25231 [details]
Proposed patch
Proposed patch fixes the issue for that specific record type.
I took a look at some other record types (e.g. DrawingRecord.) A lot of them assume a single ContinueRecord and indeed I haven't seen a case of them having more than one. But in the event that one day they do, this solution would work there as well.
Another thing I noticed is that other record types explicitly keep the ContinueRecord data separate and serialise it separately, whereas with EscherDrawingRecord this was not the case. This may not be a problem though, I just thought it was worth noting.
Created attachment 25232 [details]
Proposed patch
Newer version after our own review.
|