Summary: | Improve the output of the SMTPSampler | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Luciana Moreira <moreira> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | hauser |
Priority: | P3 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: | Patch to for a nicer presentation of the request on SMTPSampler |
Description
Luciana Moreira
2010-09-02 07:13:35 UTC
Created attachment 25968 [details]
Patch to for a nicer presentation of the request on SMTPSampler
Thanks, good patch. However, I wonder why the From:/Reply-To: etc. headers are treated specially - would it not be better to use the actual headers? Also, there were quite a few tabs in the patch - please could you use spaces instead in future? [Eclipse has a setting for this.] Applied to SVN: URL: http://svn.apache.org/viewvc?rev=992129&view=rev Log: Bug 49862 - Improve SMTPSampler Request output. Modified: jakarta/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/SmtpSampler.java jakarta/jmeter/trunk/xdocs/changes.xml I made a few changes: - split output into samplerData and RequestHeaders - moved setup so even failed samples show the request data - eliminated duplication of header output Hello Sebb, I will configure Eclipse to avoid the tab problem :-) I treated the From:/Reply-TO: etc differently only to be able to display them together after all other tags. I only did this because otherwise it is a bit annoying to try to find this information in the middle of all the other tags. But I can live with them being displayed out of order. OK, I see. Could still sort the fields if the ordering proves to be a problem. After looking into the improvements you made in the code. I must say I like it. The only thing that I believe should be changed is moving the Request Headers to the top. I saw that you separated the sample result into the body and the headers, and I think it is right! I just find it a bit odd to have the headers at the bottom... The headers are at the bottom because that's the way they are shown for HTTP(S) requests. Could potentially change to having them at the top, but then one would need to add markers to show where the body starts and ends. This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2395 |