Bug 49976

Summary: FormCharSetFinder visibility is default instead of public.
Product: JMeter Reporter: jens_0
Component: HTTPAssignee: JMeter issues mailing list <issues>
Status: RESOLVED FIXED    
Severity: enhancement CC: p.mouawad
Priority: P2    
Version: 2.5   
Target Milestone: ---   
Hardware: All   
OS: All   
Attachments: Fix the issue
Make constructor public

Description jens_0 2010-09-22 10:14:19 UTC
The class FormCharSetFinder is not public visibility as it is the case for the other classes surrounding it. This makes it more difficult to extend JMeter's proxy server with classes in another package as they cannot access FormCharSetFinder.
Comment 1 Philippe Mouawad 2011-09-17 15:38:25 UTC
Created attachment 27521 [details]
Fix the issue

Hello,
Little patch to this little enhancement.
Regards
Philippe
Comment 2 Sebb 2011-09-17 22:11:59 UTC
URL: http://svn.apache.org/viewvc?rev=1172078&view=rev
Log:
Bug 49976 - FormCharSetFinder visibility is default instead of public.

Modified:
   jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/FormCharSetFinder.java
   jakarta/jmeter/trunk/xdocs/changes.xml
Comment 3 Philippe Mouawad 2011-09-27 14:57:52 UTC
It would be also useful to have the constructor public.
I attach a patch.
Regards
Philippe
Comment 4 Philippe Mouawad 2011-09-27 14:58:28 UTC
Created attachment 27611 [details]
Make constructor public
Comment 5 Sebb 2011-09-27 15:07:05 UTC
URL: http://svn.apache.org/viewvc?rev=1176424&view=rev
Log:
Bug 49976 - FormCharSetFinder visibility is default instead of public
Make ctor public too

Modified:
   jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/FormCharSetFinder.java