| Summary: | PersistentValve.invoke - possible NPE at line 186 | ||
|---|---|---|---|
| Product: | Tomcat 7 | Reporter: | Sebb <sebb> |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | trunk | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Attachments: | Don't dereference null when generating the log message | ||
This was fixed as part of the general clean-up undertaken when getting trunk to build with Checkstyle's unused imports check enabled. The fix will be in 7.0.5 onwards. The patch was proposed for 6.0 and 5.5. |
Created attachment 26194 [details] Don't dereference null when generating the log message PersistentValve.invoke() has the code: if (session != null && ...){ } else { session.isValid() // line 186 It's quite possible that session is null in the log message.