|Summary:||URL Re-writing Modifier: extracted jsessionid value is incorrect when is between XML tags|
|Product:||JMeter||Reporter:||Gregory Lardiere <gregory.lardiere>|
|Component:||HTTP||Assignee:||JMeter issues mailing list <issues>|
Description Gregory Lardiere 2010-11-17 10:39:18 UTC
When extracted from an XML document, the jsessionid value might contains extra characters. For example, with this XML : "<url>/some/path;jsessionid=123456789</url>", the extracted jsessionid is "123456789</url". The attached patch fixes the problem by excluding the "<" character from the list of allowed characters for a jsessionid value.
Comment 2 Milamber 2010-11-19 16:08:52 UTC
Thanks for report and patch. Done in SVN URL: http://svn.apache.org/viewvc?rev=1037021&view=rev Log: Bug 50286 - URL Re-writing Modifier: extracted jsessionid value is incorrect when is between XML tags Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/URLRewritingModifier.java jakarta/jmeter/trunk/xdocs/changes.xml
Comment 3 Sebb 2010-11-20 12:56:01 UTC
I'm not sure this is fully solved. At least there needs to be a test case. So I wrote a test case - but it failed because it does not use any of the REs that have been patched. Instead it uses parameterRegexp. @Gregory: Does your test use Path Extension = true? Not sure how that could be using that for the example you gave.
Comment 4 Sebb 2010-11-20 15:34:14 UTC
(In reply to comment #3) > Not sure how that could be using that for the example you gave. Scrub that sentence - does not apply.
Comment 5 Milamber 2010-11-20 16:32:57 UTC
The solve wouldn't be adding a < in parameterRegexp? parameterRegexp = JMeterUtils.getPatternCache().getPattern( // ;sessionid=value "[;\\?&]" + quotedArg + "=([^\"'>&\\s;\\\\]*)" + // $NON-NLS-1$
Comment 6 Gregory Lardiere 2010-11-22 04:42:58 UTC
(In reply to comment #3) > @Gregory: Does your test use Path Extension = true? yes, my test uses PathExtension=true and PathExtensionNoQuestionmark=true
Comment 7 Gregory Lardiere 2010-11-22 04:51:06 UTC
(In reply to comment #5) > The solve wouldn't be adding a < in parameterRegexp? My patch solves the problem in my case (PathExtension=true). The same problem may exists as well in the "PathExtension=false" case, I didn't checked.
Comment 8 Sebb 2010-11-22 06:45:56 UTC
Thanks for confirming your settings. Code has now also been fixed for the PathExtension=false case.