| Summary: | Code:Inconsistent synchronization | ||
|---|---|---|---|
| Product: | JMeter - Now in Github | Reporter: | Philippe Mouawad <p.mouawad> |
| Component: | Main | Assignee: | JMeter issues mailing list <issues> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | p.mouawad |
| Priority: | P2 | ||
| Version: | Nightly (Please specify date) | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
Philippe Mouawad
2011-11-30 21:40:17 UTC
Date: Sun Dec 4 11:46:18 2011 New Revision: 1210091 URL: http://svn.apache.org/viewvc?rev=1210091&view=rev Log: Bug 52266 - Code:Inconsistent synchronization Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java (In reply to comment #0) > We need to check these: > Inconsistent synchronization of > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerDownloadImages; > locked 50% of time > Inconsistent synchronization of > org.apache.jmeter.functions.StringFromFile.myBread; locked 70% of time FIXED > Inconsistent synchronization of > org.apache.jmeter.functions.StringFromFile.fileName; locked 87% of time FIXED > Inconsistent synchronization of > org.apache.jmeter.protocol.http.proxy.ProxyControl.useKeepAlive; locked 50% of > time > Inconsistent synchronization of > org.apache.jmeter.visualizers.ViewResultsFullVisualizer.jTree; locked 90% of > time > Inconsistent synchronization of org.apache.jmeter.services.FileServer.base; > locked 83% of time > Inconsistent synchronization of > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerFollowRedirects; > locked 50% of time > Inconsistent synchronization of > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerRedirectAutomatically; > locked 50% of time > Inconsistent synchronization of > org.apache.jmeter.protocol.jdbc.config.DataSourceElement.excaliburSource; > locked 83% of time => Issue confirmed Date: Sun Dec 4 11:52:25 2011 New Revision: 1210093 URL: http://svn.apache.org/viewvc?rev=1210093&view=rev Log: Bug 52266 - Code:Inconsistent synchronization Modified: jmeter/trunk/src/core/org/apache/jmeter/services/FileServer.java (In reply to comment #1) > Date: Sun Dec 4 11:46:18 2011 > New Revision: 1210091 > > URL: http://svn.apache.org/viewvc?rev=1210091&view=rev > Log: > Bug 52266 - Code:Inconsistent synchronization > > Modified: > jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java > > (In reply to comment #0) > > We need to check these: > > Inconsistent synchronization of > > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerDownloadImages; > > locked 50% of time > > Inconsistent synchronization of > > org.apache.jmeter.functions.StringFromFile.myBread; locked 70% of time > FIXED > > Inconsistent synchronization of > > org.apache.jmeter.functions.StringFromFile.fileName; locked 87% of time > FIXED > > Inconsistent synchronization of > > org.apache.jmeter.protocol.http.proxy.ProxyControl.useKeepAlive; locked 50% of > > time > > Inconsistent synchronization of > > org.apache.jmeter.visualizers.ViewResultsFullVisualizer.jTree; locked 90% of > > time > > Inconsistent synchronization of org.apache.jmeter.services.FileServer.base; > > locked 83% of time FIXED > > Inconsistent synchronization of > > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerFollowRedirects; > > locked 50% of time > > Inconsistent synchronization of > > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerRedirectAutomatically; > > locked 50% of time > > Inconsistent synchronization of > > org.apache.jmeter.protocol.jdbc.config.DataSourceElement.excaliburSource; > > locked 83% of time => Issue confirmed URL: http://svn.apache.org/viewvc?rev=1210289&view=rev Log: Bug 52266 - Code:Inconsistent synchronization Ensure safe publication of variables Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java Date: Mon May 7 16:58:06 2012 New Revision: 1335125 URL: http://svn.apache.org/viewvc?rev=1335125&view=rev Log: Bug 52266 - Code:Inconsistent synchronization Add synchronized on openFile method will not impact performance as method is private, lock will be reentrant Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java Date: Mon May 7 20:36:26 2012 New Revision: 1335242 URL: http://svn.apache.org/viewvc?rev=1335242&view=rev Log: Bug 52266 - Code:Inconsistent synchronization Use Atomic Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java (In reply to comment #2) > Date: Sun Dec 4 11:52:25 2011 > New Revision: 1210093 > > URL: http://svn.apache.org/viewvc?rev=1210093&view=rev > Log: > Bug 52266 - Code:Inconsistent synchronization > > Modified: > jmeter/trunk/src/core/org/apache/jmeter/services/FileServer.java > (In reply to comment #1) > > Date: Sun Dec 4 11:46:18 2011 > > New Revision: 1210091 > > > > URL: http://svn.apache.org/viewvc?rev=1210091&view=rev > > Log: > > Bug 52266 - Code:Inconsistent synchronization > > > > Modified: > > jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java > > > > (In reply to comment #0) > > > We need to check these: > > > Inconsistent synchronization of > > > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerDownloadImages; > > > locked 50% of time FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.functions.StringFromFile.myBread; locked 70% of time > > FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.functions.StringFromFile.fileName; locked 87% of time > > FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.protocol.http.proxy.ProxyControl.useKeepAlive; locked 50% of > > > time FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.visualizers.ViewResultsFullVisualizer.jTree; locked 90% of > > > time > > > Inconsistent synchronization of org.apache.jmeter.services.FileServer.base; > > > locked 83% of time > FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerFollowRedirects; > > > locked 50% of time FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.protocol.http.proxy.ProxyControl.samplerRedirectAutomatically; > > > locked 50% of time FIXED > > > Inconsistent synchronization of > > > org.apache.jmeter.protocol.jdbc.config.DataSourceElement.excaliburSource; > > > locked 83% of time => Issue confirmed Date: Fri Aug 24 18:51:51 2012 New Revision: 1377045 URL: http://svn.apache.org/viewvc?rev=1377045&view=rev Log: Bug 52266 - Code:Inconsistent synchronization Bugzilla Id: 52266 Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java jmeter/trunk/xdocs/changes.xml URL: http://svn.apache.org/r1521665 Log: Code:Inconsistent synchronization AtomicBoolean and AtomicInt are not necessary when values are simply written and read and the previous value is irrelevant (e.g. AtomicInt would be needed if the value was incremented) Bugzilla Id: 52266 Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2664 |