Summary: | TCP Sampler in "reuse connection mode" reuses previous sampler's connection even if it's configured with other host, port, user or password | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | sanjiely <sanjiely> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | p.mouawad |
Priority: | P2 | ||
Version: | 2.5.1 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
sanjiely
2011-12-29 08:08:09 UTC
Date: Thu Dec 29 16:45:11 2011 New Revision: 1225587 URL: http://svn.apache.org/viewvc?rev=1225587&view=rev Log: Bug 52396 - TCP Sampler in "reuse connection mode" reuses previous sampler's connection even if it's configured with other host, port, user or password Modified: jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java jmeter/trunk/xdocs/changes.xml Fixed in trunk, use nightly build as soon as it's available and report if issue is fixed or not: https://builds.apache.org/job/JMeter-trunk/lastSuccessfulBuild/artifact/trunk/dist/ Hi, Thank you for your quick reply. I haven't tried the nightly build but read the code, and I find it is able to support multi-connections reused now. But maybe here is a minor issue, from the method "threadFinished": public void threadFinished() { log.debug("Thread Finished"); //$NON-NLS-1$ closeSocket(); if (protocolHandler != null){ protocolHandler.teardownTest(); } The closeSocket method is called, and it will only remove and close the current TCP connection. The other re-used connections will not be closed. Maybe we need a method like closeAllSockets called by threadFinished to traverse all connections to close them. Thanks. Good point, fixed. Date: Sat Dec 31 10:52:39 2011 New Revision: 1226061 URL: http://svn.apache.org/viewvc?rev=1226061&view=rev Log: Bug 52396 - TCP Sampler in "reuse connection mode" reuses previous sampler's connection even if it's configured with other host, port, user or password Modified: jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2692 |