Bug 52438

Summary: [PATCH] Patch to CellDateFormatter for formats with hours and minutes but not seconds
Product: POI Reporter: Steve Vysny <steve.vysny>
Component: POI OverallAssignee: POI Developers List <dev>
Severity: normal    
Priority: P2    
Version: 3.8-dev   
Target Milestone: ---   
Hardware: All   
OS: All   
Attachments: Patch svn diff
DateFormatTests.xlsx with new test

Description Steve Vysny 2012-01-08 16:34:49 UTC
Created attachment 28123 [details]
Patch svn diff

Attached patch resolves issue in CellDataFormatter that causes date-time values to be formatted incorrectly for a format with hours and minutes but not seconds (e.g. "h:m").

New test case added to DateFormatTests.xlsx (sheet 'Tests', row 42).

Additional change to DateFormatTests.xlsx: on sheet 'Flags', deleted value of Categories flag and changed value of AllColors flag to True, so that all tests in the workbook are run.
Comment 1 Steve Vysny 2012-01-08 16:39:17 UTC
Created attachment 28124 [details]
DateFormatTests.xlsx with new test
Comment 2 Nick Burch 2012-01-09 18:22:43 UTC
Thanks, patch applied in r1229281.

(As an aside, this code looks to duplicate some of the things in DataFormatter, so long term we should probably try to merge the logic of the two where possible)