| Summary: | JspC : checking uriRoot option validness | ||
|---|---|---|---|
| Product: | Tomcat 7 | Reporter: | Eugene Chung (TmaxSoft) <bluewolf.chung> |
| Component: | Jasper | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | ||
| Priority: | P2 | ||
| Version: | trunk | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
And !uriRootF.exists() || !uriRootF.isDirectory() is redundant. isDirectory() checks existence, too. Thanks for the report and the suggested fix. This issue has been fixed in trunk and 7.0.x and will be included in 7.0.27 onwards. |
In org.apache.jasper.JspC#execute() method, if uriRoot is not null, it scans all jsp files under uriRoot, and then checks if uriRoot is a directory. It should be more desirable to check if uriRoot is a directory or not first and then scanning it. Here are my suggestion. if (uriRoot == null) { throw new JasperException( Localizer.getMessage("jsp.error.jspc.no_uriroot")); } File uriRootF = new File(uriRoot); if (!uriRootF.exists() || !uriRootF.isDirectory()) { throw new JasperException( Localizer.getMessage("jsp.error.jspc.uriroot_not_dir")); } if( context==null ) { initServletContext(); } // No explicit pages, we'll process all .jsp in the webapp if (pages.size() == 0) { scanFiles(uriRootF); }