Bug 53016

Summary: missing apr_brigade_destroy
Product: Apache httpd-2 Reporter: Julia Lawall <jlawall>
Component: mod_proxy_ajpAssignee: Apache HTTPD Bugs Mailing List <bugs>
Status: RESOLVED FIXED    
Severity: normal Keywords: FixedInTrunk, PatchAvailable
Priority: P2    
Version: 2.5-HEAD   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Attachments: patch adding missing call to apr_brigade_destroy

Description Julia Lawall 2012-03-31 20:19:56 UTC
Created attachment 28524 [details]
patch adding missing call to apr_brigade_destroy

Input_brigade is allocated in ap_proxy_ajp_request.  On most error paths it is freed with apr_brigade_destroy.  This patch adds a call to apr_brigade_destroy in the remaining case.
Comment 1 Christophe JAILLET 2018-05-27 20:48:28 UTC
Fixed in r1832351.
Thx for the report, and sorry for the really long delay.

Maybe it's time to add some error handling gotos in apache, Linux style :)
Comment 2 Christophe JAILLET 2018-08-22 05:09:04 UTC
Backported in 2.4.x in r1838103.

Will be part of 2.4.35.