Summary: | Give PoolCleaner TimerTask a better name | ||
---|---|---|---|
Product: | Tomcat Modules | Reporter: | Michael Osipov <michaelo> |
Component: | jdbc-pool | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | minor | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | Pool Cleaner name |
Description
Michael Osipov
2012-04-17 07:30:25 UTC
Created attachment 28620 [details]
Pool Cleaner name
I am marking this invalid since 1. Singleton is only a relative term to a classloader. An app that embeds this library can start up two different pools in two different classloaders 2. The thread, even in a single class loader system can change names - since the timer thread, while being a singleton, can be stopped, and then started as pools start and stop throughout the runtime of the JVM. The name currently helps identify what classloader started it, and what time it started. Filip, partially agreed but why can't we still have a better name? What about "Tomcat JDBC Pool Cleaner[<number>:<number>]" Reopen, put in a more descriptive name Finally, thanks! |